🐛 Propogate permissions to child works & filesets #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
force-pushed
the
i347-propogate-permissions-to-fileset
branch
from
ef4c7c5
to
fd4d14c
Compare
Copies the permissions from the parent work to each of the spawned child works. Prior to this commit, the child works split off of parent works were assigned permissions according to the parent's current visibility (in the case of a lease or embargo, this means they were assigned the value during lease or embargo). This would protect the child work during the lease or embargo period but not allow it to be maintained by the expiry jobs, resulting in an incorrect visibility setting at the end of the lease or embargo.
laritakr
force-pushed
the
i347-propogate-permissions-to-fileset
branch
from
fd4d14c
to
f2d58f3
Compare
ShanaLMoore
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Copies the permissions from the parent work to each of the spawned child works.
Prior to this commit, the child works split off of parent works were assigned permissions according to the parent's current visibility (in the case of a lease or embargo, this means they were assigned the value during lease or embargo).
This would protect the child work during the lease or embargo period but not allow it to be maintained by the expiry jobs, resulting in an incorrect visibility setting at the end of the lease or embargo.
Refs #347
Expected Behavior Before Changes
Child works were assigned the visibility of the parent. In cases of embargo or lease, this means they were assigned the initial "visibility during..." value.
Expected Behavior After Changes
Child works and child filesets are assigned the same permissions as the parent work.
Screenshots / Video
Child Work
Notes
Testing is blocked by #343
Due to an unknown source of a change in behavior, filesets in Hyku/hyrax double-combo are still only assigned the initial 'visibility during...' value. This should be addressed in a separate ticket.